Add syntax highlighting for MIB files
ClosedPublic

Authored by jkeuter on Mar 1 2018, 10:49 PM.

Details

Summary

Add a syntax file for MIBs, as well as a test mib.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jkeuter created this revision.Mar 1 2018, 10:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 1 2018, 10:49 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
jkeuter requested review of this revision.Mar 1 2018, 10:49 PM

Compiling results in:

Error XSDError in file:///home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/mib.xml, at line 4, column 165: Content of attribute version does not match its type definition: 1.0 is not valid according to xs:integer..
Version must be an int nowadays, so I changed "1.0" to "1".

Further:
katehighlightingindexer(6406)/(default) {anonymous}::AttributeChecker::check: "/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/mib.xml" Reference of non-existing itemData attributes: QSet("String Char")

I added an itemData "Char" with dsChar.

Calling make test creates the reference unit test data, this was missing. I did this now, adding:

new file:   autotests/folding/test.mib.fold
new file:   autotests/html/test.mib.html
new file:   autotests/reference/test.mib.ref
dhaumann accepted this revision.Mar 3 2018, 11:13 AM

Looks ok to me now.

Please get an update of the committed file, and please maintain this file within the syntax-highlighting framework in the future.

This revision is now accepted and ready to land.Mar 3 2018, 11:13 AM
This revision was automatically updated to reflect the committed changes.