[kaccess] Improve the port away from kdelibs4support
ClosedPublic

Authored by kossebau on Mar 1 2018, 10:39 PM.

Details

Summary

Follow-up to 1ded47814a614debefd465cf8f962db4b8163822

  • for proper D-Bus well-known name set app data before registering
  • QT_QPA_PLATFORM better set before creating the QApp instance

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 1 2018, 10:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2018, 10:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Mar 1 2018, 10:39 PM

No related bug known, I only stumbled over the D-Bus name by accident. And think that one ideally follows standards, even if just used for ensuring singleton (?).

Not exactly sure when QT_QPA_PLATFORM should be set, but all Qt code I found did it before the QApp instance creation, and there might be some chance that the env is already used in the instance constructor.

davidedmundson accepted this revision.Mar 6 2018, 11:39 AM
This revision is now accepted and ready to land.Mar 6 2018, 11:39 AM
This revision was automatically updated to reflect the committed changes.