Differential D10941

SMTP sending: Option to use system proxy settings (transport config and GUI)
ClosedPublic
Actions

Authored by marten on Mar 1 2018, 1:15 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R84:b536593f5bfa: Mail transport setting and GUI for the SMTP proxy option
Summary

This is to provide an explicit option to not use the system proxy setting for SMTP connections, as described in T7430.

D10940 implements the proxy option in KSmtp. This is the GUI for the setting, which appears as an additional option in the "Advanced" tab of the transport settings dialogue.

Test Plan

Built kmailtransport with this change. Verified that the account option is correctly saved in the transport configuration file, and that it controls whether SMTP connections are made via the proxy.

Diff Detail

Repository
R84 PIM: KMail Transport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Mar 1 2018, 1:15 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 1 2018, 1:15 PM
marten requested review of this revision.Mar 1 2018, 1:15 PM
marten edited the summary of this revision. (Show Details)
dvratil accepted this revision.Mar 2 2018, 8:50 AM
dvratil added a subscriber: dvratil.

Looks good, thanks!

This revision is now accepted and ready to land.Mar 2 2018, 8:50 AM
Closed by commit R84:b536593f5bfa: Mail transport setting and GUI for the SMTP proxy option (authored by marten). · Explain WhyMar 2 2018, 2:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28409

View Options

src/kmailtransport/mailtransport.kcfg

Loading...
View Options

src/kmailtransport/plugins/smtp/smtpjob.cpp

Loading...
View Options

src/kmailtransport/plugins/smtp/smtpsettings.ui

Loading...