auto hide popup when it opened itself
ClosedPublic

Authored by mart on Feb 28 2018, 4:16 PM.

Details

Summary

when the device notifier pops up automatically, leave it open
if there is no user activity, if there is any, close after around
3 seconds. Suspend the countdown if the notifier window either has
focus or the mouse cursor is over it, leaving the user the time to
go interact. if it doesn't have focus and the mouse leaves, resume
the countdown
replaces D10591

Test Plan

tested for a while in a real world usage, it behaves in a fairly natural
way

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/notifierIdleTime
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Feb 28 2018, 4:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 28 2018, 4:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Feb 28 2018, 4:16 PM

If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice animated pop-ups in the corner of the screen as fast as you or I do. I would advocate for a minimum of 5 seconds, or even a bit longer.

mart added a comment.Feb 28 2018, 4:48 PM

If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice animated pop-ups in the corner of the screen as fast as you or I do. I would advocate for a minimum of 5 seconds, or even a bit longer.

should be tested... with this code, for.. "reasons", i always wait for 2 timeouts, so would be around 6 seconds tough variable, all depends on the last user activity (one could argue "most of the times" the popup goes up for manual insertion of a thumbdrive, which means no user action at that moment, so the popup would stay "forever" until the user moves the mouse again or types stuff, then the 2*3 seconds timeout starts

In D10921#215717, @mart wrote:

If we do this, I'm not sure that 3 seconds is enough for most users. A lot of people don't notice animated pop-ups in the corner of the screen as fast as you or I do. I would advocate for a minimum of 5 seconds, or even a bit longer.

should be tested... with this code, for.. "reasons", i always wait for 2 timeouts, so would be around 6 seconds tough variable, all depends on the last user activity (one could argue "most of the times" the popup goes up for manual insertion of a thumbdrive, which means no user action at that moment, so the popup would stay "forever" until the user moves the mouse again or types stuff, then the 2*3 seconds timeout starts

That seems fairly reasonable to me.

mart added a comment.Feb 28 2018, 5:02 PM

That seems fairly reasonable to me.

so, what i would like is to have this early in the cycle, so there is plenty of time to test for who has master, or neon devel unstable and still tweak it to be perfect before 5.13 release

broulik accepted this revision.Mar 1 2018, 3:50 PM
This revision is now accepted and ready to land.Mar 1 2018, 3:50 PM
This revision was automatically updated to reflect the committed changes.