In 0d6792c I turned the JS into a singleton but overlooked that it also accesses plasmoid context property.
Instead of randomly calling outside objects from this library function, signal what the caller should do.
The function already returned undefined for doing nothing, and true for requesting a close. Changed all call sites of this function to explicitly check for true
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R119:68667160e07b: [Kickoff / Kicker] Request closing plasmoid properly
- Adding app to desktop from Kickoff closed menu
- Adding app to desktop from Kicker closed menu
- Adding app to desktop from dashboard closed dashboard
- Adding an item to favorites did not close the menu
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped