[Kickoff / Kicker] Request closing plasmoid properly
ClosedPublic

Authored by broulik on Feb 28 2018, 10:39 AM.

Details

Summary

In 0d6792c I turned the JS into a singleton but overlooked that it also accesses plasmoid context property.
Instead of randomly calling outside objects from this library function, signal what the caller should do.
The function already returned undefined for doing nothing, and true for requesting a close. Changed all call sites of this function to explicitly check for true

Test Plan
  • Adding app to desktop from Kickoff closed menu
  • Adding app to desktop from Kicker closed menu
  • Adding app to desktop from dashboard closed dashboard
  • Adding an item to favorites did not close the menu

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 28 2018, 10:39 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 28 2018, 10:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 28 2018, 10:39 AM
hein accepted this revision.Feb 28 2018, 11:37 AM
This revision is now accepted and ready to land.Feb 28 2018, 11:37 AM
This revision was automatically updated to reflect the committed changes.