This makes the working of the display button much more intuitive.
FEATURE: 390096
dvratil |
Plasma |
This makes the working of the display button much more intuitive.
FEATURE: 390096
Tested with external display plugged in, system behaves as expected
No Linters Available |
No Unit Test Coverage |
Hmm, I guess you can now kill m_buttonTimer, m_iteration, resetDisplaySwitch() and applyGenericConfig() as well, as those are used exclusively by the config iteration. You probably also want to check if the Selection OSD is already shown, otherwise pressing the Display Button multiple times would create multiple OSDs.
OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already there, if that's OK from your POV.
As to the other cleanups: Good point, I'll submit an updated version of this patch shortly.