Differential D10874

Make sure we don't crash when stopping all jobs
ClosedPublic
Actions

Authored by apol on Feb 26 2018, 5:01 PM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R32:8430d3058f92: Make sure we don't crash when stopping all jobs
Summary

If we don't emit result, the ExecuteCompositeJob doesn't relise that
it's failing and keeps the dangling object. Calling stop all processes
would result in a crash then.

Test Plan
  • run app
  • run app again
  • choose to kill the first instance
  • stop all processes

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 26 2018, 5:01 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 26 2018, 5:01 PM
apol requested review of this revision.Feb 26 2018, 5:01 PM
mwolff added a subscriber: mwolff.Feb 26 2018, 7:53 PM

we got tons of reports for crashes in this regard, is this the reason? are there maybe more places that this needs to be fixed? one way or another, I think you can add at least one BUG: line

mwolff accepted this revision.Feb 26 2018, 7:57 PM
This revision is now accepted and ready to land.Feb 26 2018, 7:57 PM
apol added a comment.Feb 27 2018, 1:58 AM

we got tons of reports for crashes in this regard, is this the reason? are there maybe more places that this needs to be fixed? one way or another, I think you can add at least one BUG: line

Have been looking for a bug, couldn't find it.
I'll backport it to 5.2.

¯\_(ツ)_/¯

Closed by commit R32:8430d3058f92: Make sure we don't crash when stopping all jobs (authored by apol). · Explain WhyFeb 27 2018, 1:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugins/execute/nativeappjob.cpp (2 lines)

Diff 28159

View Options

plugins/execute/nativeappjob.cpp

Loading...