Rename wallpaper translation catalogs to follow pattern
ClosedPublic

Authored by kossebau on Feb 26 2018, 7:06 AM.

Details

Summary

The wallpaper loading code expects the catalogs to follow the pattern
"plasma_wallpaper_" + pluginid. While in config QML the domain needs
to be explicitly set using i18nd, as the default textdomain is set to
that of the config container, it is not needed in the wallpaper QML.

While using a catalog with plasma_applet_* prefix works if setting
the domain explicitly, the usage goes against the design of the
naming patterns. So to give a good example and also properly marking
the usage of the catalog, the names are switched.

Diff Detail

Repository
R120 Plasma Workspace
Branch
fixwallpapercatalognames
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Feb 26 2018, 7:06 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2018, 7:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Feb 26 2018, 7:06 AM
davidedmundson accepted this revision.Mar 20 2018, 4:40 PM
davidedmundson added a subscriber: davidedmundson.

If you do rename any catalogs please inform kde-i18n-doc so they can move any existing translations

This revision is now accepted and ready to land.Mar 20 2018, 4:40 PM
This revision was automatically updated to reflect the committed changes.