LocalLister: always append trailing slash if it's a folder
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 24 2018, 5:37 PM.

Details

Reviewers

sandsmark
sitter

Commits

Summary

We were adding the trailing slash only when recursively calling scan(),
but we need to do the same also when calling Folder::append().

Test Plan

filelight ~/home/foo/bar
go up to ~/home/foo
check whether /home/foo/bar has the trailing slash in the relevant map tooltips.

Repository

R352 Filelight

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Meh. The entire codebase seems to often be guessing if it needs to append a slash or not. It's fairly dishearting.

Change looks fine. All code based on m_name of the Folder should be fine with this at a glance.

This revision is now accepted and ready to land.Feb 26 2018, 11:30 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/localLister.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27934	96026dc		Feb 24 2018, 5:37 PM	★	★
Diff 2	28142	96026dc	R352:c353bb21f2b5d56692ddafb673a66a5f49bb272c	Feb 26 2018, 9:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
36bef5a8d2f0	bc1e91d29450	96026dcd6c56	Elvis Angelaccio	LocalLister: always append trailing slash if it's a folder (Show More…)	Feb 24 2018, 5:27 PM