Details
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Noticed the comment missing in the "Add widget.." picker, appstreamcli also complains about missing summary entry.
I picked the string as used with the private implementation version of that widget (no clue on the details though).
Fix would be for 5.12 branch.
While at it, any idea for a better icon? "preferences-desktop-notification" does not make that much sense, also duplicates the one used for the notifications applet.
Has there been already a request for a custom icon be filed? Otherwise I would do that.
Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc.
Has there been already a request for a custom icon be filed
Don't think so
Given I just copied the same string as used for the metadata of the internal grouping package and all desktop files being merged into one catalog per module, translators should not be really effected here though, as it will just mean the same string with same context used in another place :)
Cmp. https://websvn.kde.org/branches/stable/l10n-kf5/templates/messages/kde-workspace/desktop_workspace_kdeplasma-addons.pot?view=markup
So would not grep their attention for this one.
Has there been already a request for a custom icon be filed
Don't think so
K, Will file one.
Thanks for review