Isn't

q->d->fixFile_0();

the same as

fixFile_0();

?

Ah, here's a nice one: can't we add a method to the plugin that takes care of the detection? We pass the qbaFileHeader and the plugin tells us, if it is capable of reading the file (no matter how). This way, we can eliminate the GNC stuff here and move it into the plugin.

Can't the

QString::fromLatin1("~")

be a

QLatin1String("~")

?

Same here: the plugin should take care of adding it's own stuff that it supports. E.g.

const QString fileExtension = plugin->fileExtension();
if (!fileExtension.isEmpty()) {
  fileExtensions.append(fileExtension);
  fileExtensions.append(QLatin1String(";;"));
}

No break, because it could have multiple plugins which can read their data file.

I think it's a good idea to have all GNC stuff in GNC plugin.

I think, that instead of moulding every storage plugin to pReader we could only require MyMoneyStorageMgr filled up like in the case of SQL.

I think it's not good to pass qbaFileHeader, because database can be just a url to connect to and not a physical file you can read through.

I would like to divide that method further, shake off some more unneeded stuff and create XML storage plugin. Then we could have handlers of files in plugins which would be self contained units.

I think the change you request could go in follow-up patches.

QStringLiteral is more appropriate here. Please check header file of KBackup::numberedBackupFile.

I think it could be arranged.