Part 2 Clean up MainWindow
ClosedPublic

Authored by laysrodrigues on Feb 24 2018, 5:17 AM.

Details

Summary

This step was done so we can adpat with
sucess the use of AtCoreInstanceWidget.

  • Remove management of AtCore from MainWindow
  • Use a Toolbox instead of DockWidgets
  • Removed non needed actions from atelierui.rc

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Adapt MainWindow to use AtCoreInstaceWidget

Created a method that create new instances of atcore
and append the new instance in the tab widget.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Create a method only to do the connections

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues requested review of this revision.Feb 24 2018, 5:17 AM
laysrodrigues created this revision.
rizzitello requested changes to this revision.Feb 24 2018, 1:15 PM

Needs rebase to master.

src/mainwindow.h
23

New empty space

This revision now requires changes to proceed.Feb 24 2018, 1:15 PM
rizzitello added inline comments.Feb 24 2018, 1:21 PM
src/widgets/atcoreinstancewidget.h
71 ↗(On Diff #27895)

New Empty line

patrickelectric requested changes to this revision.Feb 24 2018, 4:50 PM
patrickelectric added inline comments.
src/mainwindow.cpp
52

reference

rizzitello added inline comments.Feb 24 2018, 9:38 PM
src/mainwindow.h
40

This needs to be rebased to master

laysrodrigues marked 2 inline comments as done.

Rebase and fixes

rizzitello requested changes to this revision.Feb 25 2018, 2:04 AM
rizzitello added inline comments.
src/mainwindow.cpp
41–42

Empty Function

This revision now requires changes to proceed.Feb 25 2018, 2:04 AM

Rebase and fixes

rizzitello added inline comments.Feb 25 2018, 7:28 PM
src/mainwindow.cpp
62

why are we now giving the dialog two empty string lists?

laysrodrigues added inline comments.Feb 25 2018, 7:32 PM
src/mainwindow.cpp
62

Those data get from AtCore, and since I'm cleaning up this and moving all the management to AtCoreInstanceWidget, for now, I choose to pass empty strings.
I think that we need a better way to get that info without using an instance of AtCore to get it.
Like to use a definition as its used to get the version, so I can only import the data that I need.

rizzitello requested changes to this revision.Feb 25 2018, 7:35 PM
rizzitello added inline comments.
src/mainwindow.cpp
62

I think that we need a better way to get that info without using an instance of AtCore to get it.

These are problems that need to be solved before we go removing atcore from the main window..

This revision now requires changes to proceed.Feb 25 2018, 7:35 PM
rizzitello added inline comments.Feb 27 2018, 2:04 AM
src/mainwindow.cpp
62

D10846 to solve the above issue

patrickelectric requested changes to this revision.Feb 27 2018, 1:34 PM
patrickelectric added inline comments.
src/mainwindow.cpp
54

const ref

62

If this case exist, should be the default variables value for this constructor.

rizzitello added inline comments.Feb 27 2018, 1:39 PM
src/mainwindow.cpp
62

This will be resolved by D10846. This diff is planed to be based upon that.

laysrodrigues marked an inline comment as done.Feb 28 2018, 1:39 AM

Rebase and fixes.

rizzitello added inline comments.Feb 28 2018, 9:49 PM
src/mainwindow.cpp
88

can we just do AtCoreInstanceWidget *instance = ui->tabWidget->currentWidget()); ? its less to read and auto is doing this anyway.

rizzitello added inline comments.Feb 28 2018, 9:52 PM
src/mainwindow.cpp
88

Should this be done with a smart pointer @patrickelectric ?

rizzitello accepted this revision.Mar 1 2018, 8:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 11:08 AM
This revision was automatically updated to reflect the committed changes.