Details

Reviewers

rizzitello
tcanabrava
patrickelectric

Commits

R231:9d1428f159e3: Clean up MainWindow
R231:aaa08f990caa: Adapt MainWindow to use AtCoreInstaceWidget

Summary

This step was done so we can adpat with
sucess the use of AtCoreInstanceWidget.

Remove management of AtCore from MainWindow
Use a Toolbox instead of DockWidgets
Removed non needed actions from atelierui.rc

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Adapt MainWindow to use AtCoreInstaceWidget

Created a method that create new instances of atcore
and append the new instance in the tab widget.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Create a method only to do the connections

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Branch

part2

Lint

No Linters Available

Unit

No Unit Test Coverage

laysrodrigues requested review of this revision.Feb 24 2018, 5:17 AM

laysrodrigues created this revision.

Needs rebase to master.

src/mainwindow.h
23	New empty space

This revision now requires changes to proceed.Feb 24 2018, 1:15 PM

rizzitello added inline comments.Feb 24 2018, 1:21 PM

src/widgets/atcoreinstancewidget.h
71 ↗	(On Diff #27895)	New Empty line

patrickelectric requested changes to this revision.Feb 24 2018, 4:50 PM

patrickelectric added inline comments.

src/mainwindow.cpp
60	reference

rizzitello added inline comments.Feb 24 2018, 9:38 PM

src/mainwindow.h
40	This needs to be rebased to master

Rebase and fixes

rizzitello requested changes to this revision.Feb 25 2018, 2:04 AM

rizzitello added inline comments.

src/mainwindow.cpp
45	Empty Function

This revision now requires changes to proceed.Feb 25 2018, 2:04 AM

Rebase and fixes

Bad arc =/

rizzitello added inline comments.Feb 25 2018, 7:28 PM

src/mainwindow.cpp
71	why are we now giving the dialog two empty string lists?

laysrodrigues added inline comments.Feb 25 2018, 7:32 PM

src/mainwindow.cpp
71	Those data get from AtCore, and since I'm cleaning up this and moving all the management to AtCoreInstanceWidget, for now, I choose to pass empty strings. I think that we need a better way to get that info without using an instance of AtCore to get it. Like to use a definition as its used to get the version, so I can only import the data that I need.

rizzitello requested changes to this revision.Feb 25 2018, 7:35 PM

rizzitello added inline comments.

src/mainwindow.cpp
71	I think that we need a better way to get that info without using an instance of AtCore to get it. These are problems that need to be solved before we go removing atcore from the main window..

This revision now requires changes to proceed.Feb 25 2018, 7:35 PM

rizzitello mentioned this in D10845: Expose baudlist.Feb 26 2018, 2:30 AM

rizzitello added inline comments.Feb 27 2018, 2:04 AM

src/mainwindow.cpp
71	D10846 to solve the above issue

patrickelectric requested changes to this revision.Feb 27 2018, 1:34 PM

patrickelectric added inline comments.

src/mainwindow.cpp
62	const ref
71	If this case exist, should be the default variables value for this constructor.

rizzitello added inline comments.Feb 27 2018, 1:39 PM

src/mainwindow.cpp
71	This will be resolved by D10846. This diff is planed to be based upon that.

laysrodrigues marked an inline comment as done.Feb 28 2018, 1:39 AM

Rebase and fixes.

rizzitello added inline comments.Feb 28 2018, 9:49 PM

src/mainwindow.cpp
103	can we just do `AtCoreInstanceWidget *instance = ui->tabWidget->currentWidget());` ? its less to read and auto is doing this anyway.

rizzitello added inline comments.Feb 28 2018, 9:52 PM

src/mainwindow.cpp
109	Should this be done with a smart pointer @patrickelectric ?

rizzitello accepted this revision.Mar 1 2018, 8:51 PM

Rebase

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 11:08 AM

Closed by commit R231:9d1428f159e3: Clean up MainWindow (authored by laysrodrigues). · Explain Why

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/atelierui.rc (13 lines)
M			src/mainwindow.h (20 lines)
M			src/mainwindow.cpp (313 lines)
M			src/mainwindow.ui (234 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27895	c0e1523		Feb 24 2018, 5:17 AM	★	★
Diff 2	27973	2e6c3f2	Rebase and fixes	Feb 25 2018, 1:02 AM	★	★
Diff 3	28055	efc3a3b	Rebase and fixes	Feb 25 2018, 7:09 PM	★	★
Diff 4	28057	dd4a0c7	Bad arc =/	Feb 25 2018, 7:11 PM	★	★
Diff 5	28239	129daa9	Rebase and fixes.	Feb 28 2018, 1:45 AM	★	★
Diff 6	28388	76106a2	Rebase	Mar 2 2018, 11:07 AM	★	★
Diff 7	28389	76106a2	R231:9d1428f159e380123631823a7cd50969082ebe30	Mar 2 2018, 11:03 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f42d880562d4	d9e0b3f5adf1	d5f4351d905e	Lays Rodrigues	Adapt MainWindow to use AtCoreInstaceWidget (Show More…)	Feb 24 2018, 4:17 AM
d5f4351d905e	3fe274658da7	2e6c3f2c5ea8	Lays Rodrigues	Clean up MainWindow (Show More…)	Feb 24 2018, 4:06 AM

Part 2 Clean up MainWindow
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 27973

src/atelierui.rc

src/mainwindow.h

src/mainwindow.cpp

src/mainwindow.ui

Part 2 Clean up MainWindowClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 27973

src/atelierui.rc

src/mainwindow.h

src/mainwindow.cpp

src/mainwindow.ui

Part 2 Clean up MainWindow
ClosedPublic
Actions

Revision Contents
Changeset List