Differential D10775

Fix build with VLC<3
ClosedPublic
Actions

Authored by arojas on Feb 23 2018, 5:11 PM.

Details

Reviewers
sitter
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
R489:ea4d78ac3fc0: Fix build with VLC<3
Summary

libvlc_title_description_t and libvlc_chapter_description_t are not defined in vlc < 3.

Note that this revision is for the phonon-vlc repo rather than phonon, but it doesn't seem to be available in Phabricator

Test Plan

Builds with VLC 2.2.8 and 3.0.0

Diff Detail

Repository
R487 Phonon
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Feb 23 2018, 5:11 PM
Owners added a reviewer: Restricted Owners Package.Feb 23 2018, 5:11 PM
arojas requested review of this revision.Feb 23 2018, 5:11 PM
sitter accepted this revision.Feb 23 2018, 8:30 PM

Please push to 0.9 branch. Pvlc should be on phab btw.

This revision is now accepted and ready to land.Feb 23 2018, 8:30 PM
sitter added a comment.Feb 23 2018, 8:30 PM

Eh 0.10 of course ;)

Closed by commit R489:ea4d78ac3fc0: Fix build with VLC<3 (authored by arojas). · Explain WhyFeb 23 2018, 8:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mediaplayer.h (2 lines)

Diff 27863

View Options

src/mediaplayer.h

Loading...