Differential D10774

[Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine
ClosedPublic
Actions

Authored by broulik on Feb 23 2018, 4:39 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:2a935337c111: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine
Summary

I noticed in GammaRay there were two QQmlEngine instances in a Plasma session and found this.

Test Plan

Shell still comes up

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 23 2018, 4:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2018, 4:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 23 2018, 4:39 PM
broulik updated this revision to Diff 27862.Feb 23 2018, 4:43 PM
  • Remove debug
mart accepted this revision.Feb 26 2018, 2:57 PM
This revision is now accepted and ready to land.Feb 26 2018, 2:57 PM
Closed by commit R120:2a935337c111: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine (authored by broulik). · Explain WhyFeb 26 2018, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellmanager.cpp (24 lines)

Diff 28122

View Options

shell/shellmanager.cpp

Loading...