Differential D10773

Port to QmlObjectSharedEngine in all remaining places
ClosedPublic
Actions

Authored by broulik on Feb 23 2018, 4:29 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:b284265924bd: Port to QmlObjectSharedEngine in all remaining places
Summary

OSD, Applet Alternatives, and Interactive Console were still creating their own QML engine

Test Plan
  • Changed volume, OSD showed up fine
  • Successfully switched to another clock applet
  • Brought up interactive console and ran print("hello") in it

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 23 2018, 4:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2018, 4:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 23 2018, 4:29 PM
mart accepted this revision.Feb 26 2018, 2:58 PM
This revision is now accepted and ready to land.Feb 26 2018, 2:58 PM
Closed by commit R120:b284265924bd: Port to QmlObjectSharedEngine in all remaining places (authored by broulik). · Explain WhyFeb 26 2018, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/osd.h (4 lines)
Mshell/osd.cpp (4 lines)
Mshell/shellcorona.h (4 lines)
Mshell/shellcorona.cpp (6 lines)

Diff 27860

View Options

shell/osd.h

Loading...
View Options

shell/osd.cpp

Loading...
View Options

shell/shellcorona.h

Loading...
View Options

shell/shellcorona.cpp

Loading...