Differential D10764

[AppletQuickItem] Preload applet expander only if not already expanded
ClosedPublic
Actions

Authored by broulik on Feb 23 2018, 9:47 AM.

Details

Reviewers
mart
lbeltrame
Group Reviewers
Plasma
Commits
R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded
Summary

When an applet is placed on the desktop and already shows its full representation, like Weather applet, don't create the expander item.
The DefaultCompactApplet shows the dialog when plasmoid.expanded which will be always the case and you end up with an empty window randomly showing up on startup.

Test Plan

Placed weather applet on desktop, started plasmashell, no longer got an empty window in the top left corner of the screen
Verified that kickoff still has its expander preloaded

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 23 2018, 9:47 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 23 2018, 9:47 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 23 2018, 9:47 AM
lbeltrame added a comment.Feb 23 2018, 11:07 AM

+1 from me, fixes the issue I had.

mart accepted this revision.Feb 23 2018, 11:59 AM
This revision is now accepted and ready to land.Feb 23 2018, 11:59 AM
Closed by commit R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded (authored by broulik). · Explain WhyFeb 23 2018, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27843

View Options

src/plasmaquick/appletquickitem.cpp

Loading...