Details
Diff Detail
- Repository
- R263 KXmlGui
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
@lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself.
| src/kswitchlanguagedialog_p.cpp | ||
|---|---|---|
| 99 | Not saying this is good or bad but clearly looks like Qt is missing some API there. | |
| src/kswitchlanguagedialog_p.cpp | ||
|---|---|---|
| 99 | I don't know, the problem as far as i see it is that we're trying to do this in a generic way, a regular app would just setenv before doing anything Qt related, but we can't do that, if you go to Qt and ask for a "reread locale" i'm pretty sure they're going to say "you're doing it wrong", and honestly i'm not sure i want to take that battle :D | |
Done that.
D10757 without D10758 + D10759 fixes the bug reported in https://bugs.kde.org/show_bug.cgi?id=390623
Thanks
Now includes an auto test.
It's not amazing since it doesn't totally reproduce the real world scenario but should be close enough.
Had to make two functions be exported but since the header is not installed and it's on the KDEPrivate namespace we should be fine