Reduce sidebar width
ClosedPublic

Authored by ngraham on Feb 22 2018, 10:29 PM.

Details

Summary

BUG: 385992
FIXED-IN: 5.12.3

This is a hack to work around the fact that we're using the wrong UI element for Discover's sidebar (see Bug 390928). We use a Kirigami GlobalDrawer for the sidebar, which is problematic because the GlobalDrawer's width is always a minimum of 360 pixels on the desktop--far too wide for our use case (see Bug 390927).

Replacing the GlobalDrawer with something more appropriate is going to be a lot of work, so until then, let's not torture our users with the humongous sidebar any longer and just force it to be a smaller size for now.

I think this is a vast visual improvement because it returns the focus to the content, rather than the navigation. It makes Discover feel less "fat."

Test Plan

Before, small window:

After, small window:

Before, medium window:

After, medium window:

Before, app page:

After, app page:

Before, default view:

After, default view:

We may want to consider changing the default window size to be less wide if this patch lands, since with a narrower sidebar, the main view doesn't need to be so wide.

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 22 2018, 10:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2018, 10:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 22 2018, 10:29 PM
ngraham edited the summary of this revision. (Show Details)Feb 22 2018, 10:38 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 27822.Feb 22 2018, 10:39 PM

Use the right branch

ngraham edited the test plan for this revision. (Show Details)Feb 22 2018, 10:44 PM
ngraham edited the test plan for this revision. (Show Details)Feb 22 2018, 10:51 PM
apol accepted this revision.Feb 22 2018, 10:59 PM
This revision is now accepted and ready to land.Feb 22 2018, 10:59 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Feb 23 2018, 12:25 AM

Woot! :)

In the long term, the drawers probably could use a qtquick splitview to allow the user to adjust the sizes.