Differential D10755

Add a MsmApp::skillsPath method so the skills folder is not hardcoded
ClosedPublic
Actions

Authored by antlarr on Feb 22 2018, 8:06 PM.

Details

Reviewers
Aiix
Commits
R846:ab71b7d7b05b: Add a MsmApp::skillsPath method so the skills folder is not hardcoded
Summary

The skills folder was hardcoded to /opt/mycroft/skills in MsmView.qml.
When using the openSUSE packages I'm preparing, that's changed
to ~/.mycroft/skills, so now we use that one if it exists and the
system folder in other case.

Diff Detail

Repository
R846 Mycroft Plasma integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antlarr created this revision.Feb 22 2018, 8:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2018, 8:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
antlarr requested review of this revision.Feb 22 2018, 8:06 PM
Aiix accepted this revision.Feb 23 2018, 4:50 AM
This revision is now accepted and ready to land.Feb 23 2018, 4:50 AM
Closed by commit R846:ab71b7d7b05b: Add a MsmApp::skillsPath method so the skills folder is not hardcoded (authored by Antonio Larrosa <antonio.larrosa@gmail.com>). · Explain WhyFeb 23 2018, 8:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplasmoid/contents/ui/MsmView.qml (2 lines)
Mplugin/msmapp.h (2 lines)
Mplugin/msmapp.cpp (12 lines)

Diff 27833

View Options

plasmoid/contents/ui/MsmView.qml

Loading...
View Options

plugin/msmapp.h

Loading...
View Options

plugin/msmapp.cpp

Loading...