Instead of the dreaded link button.
BUG: 390464
Instead of the dreaded link button.
BUG: 390464
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I see what you're going for here, but the "Sources" menu you're trying to add still doesn't actually work, same as the Sort menu. Is there an open Kirigami patch that this depends upon?
Also now there's a textual bug in the Description:
OK, the i18n error is gone now. But do we really need that "also available in XXXX" text at the end of the Description, anyway? Apparently nobody reads it. Maybe we should focus on polishing the main source chooser UI and get rid of that little vestigial one.
I see what you're going for here, but the "Sources" menu you're trying to add still doesn't actually work, same as the Sort menu. Is there an open Kirigami patch that this depends upon?
No, please look into how it's possible that it's not working for you. I'll be happy to fix provided the information.
You can play around with kirigami/tests/actionsMenu.qml
Got it working. I think it's better than what we have now, at least. However, the use of checkboxes in the menu is inappropriate: since the entries are mutually exclusive, we should use radio buttons instead (Same with the sort menu; see https://bugs.kde.org/show_bug.cgi?id=391144)
Turning the checkboxes into radio buttons is tracked with https://bugs.kde.org/show_bug.cgi?id=391144.
One more visual papercut: The menu is not wide enough to accommodate all the text, so long strings get cut off: