Fix focus being removed from the text input widget
ClosedPublic

Authored by antlarr on Feb 22 2018, 7:37 PM.

Details

Summary

Each time a message is received, the focus was stolen from
the text input widget, which made it nearly impossible to write
some command to mycroft. This way we only remove the focus from
the widget when we really change its text.

Test Plan

Write some text and notice the focus is constantly being removed
from the widget when the animation on the top of the plasmoid is animated.

After applying the patch, it allows to write text as expected.

Diff Detail

Repository
R846 Mycroft Plasma integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antlarr created this revision.Feb 22 2018, 7:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2018, 7:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
antlarr requested review of this revision.Feb 22 2018, 7:37 PM
Aiix accepted this revision.Feb 22 2018, 7:41 PM
This revision is now accepted and ready to land.Feb 22 2018, 7:41 PM
Closed by commit R846:307fa73adecf: Fix focus being removed from the text input widget (authored by Antonio Larrosa <antonio.larrosa@gmail.com>). · Explain WhyFeb 22 2018, 7:53 PM
This revision was automatically updated to reflect the committed changes.