Add ECMSetupQtPluginMacroNames
ClosedPublic

Authored by kossebau on Feb 22 2018, 5:30 PM.

Details

Summary

This macro helps with setting up all the boilerplate CMake code needed
to instruct automoc about the custom C++ macros used to define Qt-style
plugin class instances.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Feb 22 2018, 5:30 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptFeb 22 2018, 5:30 PM
kossebau requested review of this revision.Feb 22 2018, 5:30 PM
kossebau edited the summary of this revision. (Show Details)Feb 22 2018, 5:54 PM
kossebau updated this revision to Diff 29426.Mar 13 2018, 6:38 PM

update with documentation completed

kossebau retitled this revision from [RFC] Add ECMSetupQtPluginMacroNames to Add ECMSetupQtPluginMacroNames.Mar 13 2018, 7:01 PM
kossebau edited the summary of this revision. (Show Details)

Questions had been:
A) names of macro and arguments okay?
B) other/similar/related use cases which should be covered?
C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent approach sane or how to support someone needing some arg5?

No answers all the time mapped to: current approach okay :)

For usage & purpose of this macro see D11294, D11295, D11296

Also related:

Would push Monday, March 19th if no-one objects or has some comment.

apol added a subscriber: apol.Mar 14 2018, 3:40 PM

LGTM
Do you think it would be possible to come up with a test for it?

In D10749#225709, @apol wrote:

LGTM

Thanks for having had a look :)

Do you think it would be possible to come up with a test for it?

Sadly no experience with cmake stuff testing and no initial idea how to write such tests. So would need some days of work, where I have other things more appealing to me :(

apol accepted this revision.Mar 15 2018, 1:22 AM
This revision is now accepted and ready to land.Mar 15 2018, 1:22 AM
This revision was automatically updated to reflect the committed changes.