Differential D10741

Use Locale::name() instead of Locale::bcp47Name()
ClosedPublic
Actions

Authored by vonreth on Feb 22 2018, 12:21 PM.

Details

Reviewers
dfaure
mlaurent
kfunk
vkrause
Commits
R246:49192654fd24: Use Locale::name() instead of Locale::bcp47Name()
Summary

bcp47Name() is encoded like "en-US" the dictionary name on the other hand
is "en_US" so lets use name().

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth created this revision.Feb 22 2018, 12:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 22 2018, 12:21 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vonreth requested review of this revision.Feb 22 2018, 12:21 PM
vonreth added a comment.Feb 23 2018, 11:03 PM

Any feedback?
This patch is needed to make sonnet work on windows at all...

apol added a subscriber: apol.Feb 23 2018, 11:29 PM

Wouldn't that mean that we are either breaking other systems or that it never worked at all?

vonreth added a comment.Feb 23 2018, 11:35 PM

I think it never worked at all, or it worked in the kde3 days or what ever.
I think on a full blown KDE setup the defaults are never used as the system settings provide something different.
But to be sure, all dicts I ever seen where encoded the unix way, en_US, instead of bcp47 en-US...

dfaure accepted this revision.Feb 24 2018, 12:39 AM

You mean "it worked in kdelibs4". This is a kdelibs4->KF5 porting issue.

This revision is now accepted and ready to land.Feb 24 2018, 12:39 AM
Closed by commit R246:49192654fd24: Use Locale::name() instead of Locale::bcp47Name() (authored by vonreth). · Explain WhyFeb 24 2018, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/test_settings.cpp (6 lines)
Msrc/core/settings.cpp (2 lines)

Diff 27907

View Options

autotests/test_settings.cpp

Loading...
View Options

src/core/settings.cpp

Loading...