updated contribute, changed spinx to optional
ClosedPublic

Authored by fabianr on Feb 21 2018, 8:12 PM.

Details

Summary

Changed the contribute page, to make clearer that onecan contribute without installing Sphinx

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
fabianr requested review of this revision.Feb 21 2018, 8:12 PM
fabianr created this revision.
romangg accepted this revision.Feb 21 2018, 9:34 PM
romangg added inline comments.
source/resources/contribute.rst
4–17

Replace with:

The HIG is written in `reStructuredText <http://www.sphinx-doc.org/en/stable/rest.html>`_, a light weight markup language.

For example the chapter heading together with the first paragraph look in reStructuredText like this::
11

Replace with:

The restructuredText of the full HIG is organized into several source files. You can view and modify these source files with any text editor.
13

Put this note before the "Getting started" header below.

15

Replace with:

The source files are hosted in a `Git repo <https://cgit.kde.org/websites/hig-kde-org.git/>`_. `Sphinx <http://www.sphinx-doc.org>`_ is used to generate HTML pages from these source files. Tasks and changes are organized via `Phabricator <https://phabricator.kde.org/project/profile/264/>`_.
35

...preview changes on your local machine.

This revision is now accepted and ready to land.Feb 21 2018, 9:34 PM
romangg added inline comments.Feb 22 2018, 8:35 AM
source/resources/contribute.rst
13

Correction: put it before the "If you are new to KDE devlopment, make sure to read..." paragraph.

fabianr updated this revision to Diff 27807.Feb 22 2018, 5:52 PM
  • changes on the contribute page suggested by romangg

and a small bugfix on typhography

romangg accepted this revision.Feb 23 2018, 12:41 PM

light weight -> lightweight
look in reStructuredText like this -> looks like this in reStructured Text

source/resources/contribute.rst
19

This is still an unnecessary barrier. If we need people to do all that stuff explained on that Wiki page just to contribute to the HIG, we've clearly done it wrong.
This should only be needed for people who want to fully get into this, someone just providing a small improvement here and there should not need to set up a dev environment and Git and stuff.

This should go into a "further information" section, not in a "Do this before you contribute" area.

fabianr updated this revision to Diff 28135.Feb 26 2018, 7:20 PM
fabianr marked an inline comment as done.
  • fix typo and improved wording
fabianr closed this revision.Feb 28 2018, 8:50 PM

I landed the patch, because I think it is an improvment to the current page, but will add a task to impove it even further as Colomar suggested.