Keep monitoring until terminated by ctrl+c
Details
Details
- Reviewers
dfaure alexeymin mwolff - Group Reviewers
Baloo Frameworks - Commits
- R293:add3284efdca: balooctl monitor: Resume to wait for service
While monitor is running various permutations of
- balooctl stop
- balooctl start
- balooctl restart
- echo otto >> ~/Documents/otto.csv
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- resume-wait (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
some minor comments, otherwise lgtm
| src/tools/balooctl/monitorcommand.cpp | ||
|---|---|---|
| 45 ↗ | (On Diff #27678) | just make it i18n("Baloo died"), though I personally think that message should be improved - maybe "Baloo became unavailable" ? also, call balooIsNotAvailable() from the slot here, that way you safe one connection. Or just move the m_err output to the balooIsNotAvailable slot. |
| 61 ↗ | (On Diff #27678) | Press Ctrl + C to stop monitoring |
| 65 ↗ | (On Diff #27678) | add a m_dbusServiceWatcher->setWatchMode(QDBusServiceWatcher::WatchForOwnerChange); |
| 71 ↗ | (On Diff #27678) | see above: i18n("Waiting for Baloo to start") |
| 72 ↗ | (On Diff #27678) | see above |
| 74 ↗ | (On Diff #27678) | remove this |
| 80 ↗ | (On Diff #27678) | see above: i18n("Baloo is running") |
| 82 ↗ | (On Diff #27678) | remove this |
| src/tools/balooctl/monitorcommand.cpp | ||
|---|---|---|
| 45 ↗ | (On Diff #27678) | Can be removed completely. |