UI improvement - add expandable line edit widget
ClosedPublic

Authored by antonanikin on Feb 21 2018, 5:36 AM.

Details

Summary

The patch adds custom line edit widget which tries to expand its width to fit typed text. New widget is used by problemreporter and standardoutputview plugins to improve usability - old versions uses standard line edits with fixed size which is not comfortable for cases when we type long search string.

Old version:

New version:

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin requested review of this revision.Feb 21 2018, 5:36 AM
antonanikin created this revision.
antonanikin edited the summary of this revision. (Show Details)Feb 21 2018, 5:42 AM

Could that be a candidate for KWidgetsAddons? Though, perhaps if it turns out to be useful elsewhere it can still be moved there.

apol added a subscriber: apol.Feb 22 2018, 2:34 AM

LGTM Can you make sure it doesn't overflow on the right?

LGTM Can you make sure it doesn't overflow on the right?

I test it for this case - works well, because we overload the hint, which will be ignored by the parent layout when it too big.

Small fixes

Could that be a candidate for KWidgetsAddons? Though, perhaps if it turns out to be useful elsewhere it can still be moved there.

Ok, I will make a new revision for KWidgetsAddons, maybe this class can be useful for other KDE apps.

I suggest to include the current version into KDevelop and if KWidgetsAddons patch will be accepted, then add the corresponding fixes to our tree.

brauch accepted this revision.Mar 5 2018, 8:20 AM
brauch added a subscriber: brauch.

Looks godd, thank you!

This revision is now accepted and ready to land.Mar 5 2018, 8:20 AM
This revision was automatically updated to reflect the committed changes.