Differential D10697

Make the badge text readable on dark color schemes
ClosedPublic
Actions

Authored by mwolff on Feb 20 2018, 8:24 PM.

Details

Reviewers
broulik
hein
Commits
R119:00f113eacb03: Make the badge text readable on dark color schemes
Summary

The background color should not be used for the foreground text
color, I believe. The background color is set to theme.highlightColor,
so use theme.highlightedTextColor for the foreground. This ensures
the text is readable on a dark color scheme.

Test Plan

unreadable text before, readable now

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mwolff created this revision.Feb 20 2018, 8:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2018, 8:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mwolff requested review of this revision.Feb 20 2018, 8:24 PM
mwolff added a comment.Feb 20 2018, 8:25 PM

using breeze high contrast here, before:

after:

broulik accepted this revision.Feb 20 2018, 10:33 PM

Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls

This revision is now accepted and ready to land.Feb 20 2018, 10:33 PM
mwolff added a comment.Feb 21 2018, 9:56 AM

I did not test it with a light color scheme yet, will do that eventually and commit it then to the branch you indicated

Closed by commit R119:00f113eacb03: Make the badge text readable on dark color schemes (authored by mwolff). · Explain WhyFeb 21 2018, 7:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27637

View Options

applets/taskmanager/package/contents/ui/Badge.qml

Loading...