Make the badge text readable on dark color schemes
ClosedPublic

Authored by mwolff on Feb 20 2018, 8:24 PM.

Details

Summary

The background color should not be used for the foreground text
color, I believe. The background color is set to theme.highlightColor,
so use theme.highlightedTextColor for the foreground. This ensures
the text is readable on a dark color scheme.

Test Plan

unreadable text before, readable now

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Feb 20 2018, 8:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2018, 8:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mwolff requested review of this revision.Feb 20 2018, 8:24 PM

using breeze high contrast here, before:

after:

broulik accepted this revision.Feb 20 2018, 10:33 PM

Thanks! I assume you tested it with a light color scheme also. 5.12 branch pls

This revision is now accepted and ready to land.Feb 20 2018, 10:33 PM

I did not test it with a light color scheme yet, will do that eventually and commit it then to the branch you indicated

This revision was automatically updated to reflect the committed changes.