dont initialize app menu index in every hiding
ClosedPublic

Authored by mvourlakos on Feb 20 2018, 7:14 PM.

Details

Summary
  • hiding a menu shouldnt initialize the currentIndex to -1

at all cases. When a secondary menu is already shown then
the currentIndex should be only the index of the new menu.
This improves also the qml bindings because currentIndex
doesnt change all the time with no reason.

Test Plan

added debug messages in qml side to check the value of
currentIndex

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mvourlakos created this revision.Feb 20 2018, 7:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2018, 7:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Feb 20 2018, 7:14 PM
broulik accepted this revision.Feb 21 2018, 10:07 AM
broulik added a subscriber: broulik.

Makes sense

This revision is now accepted and ready to land.Feb 21 2018, 10:07 AM
This revision was automatically updated to reflect the committed changes.