this avoids some unwanted scene changes and speeds up the
first open a bit, also initialize the size of the dialog main item
so there is a resize less when the Dialog is first shown
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R120:b17fa4bea6f4: parent full representation to the proper window at start
difference in show time is already visible, tough still not perfect,
something else needs to improve as well
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml | ||
---|---|---|
29 | otherwise mainItem starts being sized 0x0, then on Dialog showevent, it searches for its Layout property and resizes it based on that, this makes the resize being a noop which seems a sensible micro optimization | |
applets/systemtray/systemtray.cpp | ||
346 ↗ | (On Diff #27633) | ah, if kicker doesn't use expandedrepresentation then it's not done there, tough i feel that whether qwindow::create is actually useful or not really would need better profiling, which i'm not sure how to do |
applets/systemtray/systemtray.h | ||
---|---|---|
30 ↗ | (On Diff #27715) | Why? |
applets/systemtray/systemtray.h | ||
---|---|---|
30 ↗ | (On Diff #27715) | eww, leftover |
applets/systemtray/package/contents/ui/main.qml | ||
---|---|---|
121 | Shouldn't this be a binding? |
applets/systemtray/package/contents/ui/main.qml | ||
---|---|---|
121 | not really, as is just an inizialization to have the size it will have when properly reparented when the popup is open, it's put in the StackView, so is them propely anchored and all putting a binding here would just make things more complicated and potentially different things that want to resize the same thing at once |