Details
- Reviewers
rkflx - Group Reviewers
Gwenview - Commits
- R260:e89c06e0ffc4: Add kconf_update file to migrate new sidebar/statusbar config entries
Manual test with kconf_update gwenview.upd converts
~/.config/gwenviewrc. Hint: There can be different versions of
kconf_update on a system, take care to use the kf5 version.
Tested with make install to automatically update by KDE.
Diff Detail
- Repository
- R260 Gwenview
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| app/gwenview.upd | ||
|---|---|---|
| 3 | Should we use a version as update ID / which one? Or another descriptive name? | |
Will look at this at a more appropriate time, because we should get this 100% right.
| app/gwenview.upd | ||
|---|---|---|
| 3 | Looking at /usr/share/kconf_update/, it's all over the place. Not sure the version is really relevant, though, think of upgrading from 17.08 to 18.12. Perhaps SideBar_StatusBar_Rename? | |
Renamed update ID
| app/gwenview.upd | ||
|---|---|---|
| 3 | It's just a distinct ID to mark this update done in ~/.config/kconf_updaterc. I think a descriptive name is really better than a (possibly incorrect) version. ~/.config/gwenviewrc [$Version] update_info=gwenview.upd:gwenview18.03 | |
Looked at this carefully now, works great.
At first I kept pulling my hair out why [SideBar-BrowseMode] was not removed (apparently), but then I realized I needed D10687 for that. Note that Phabricator allows to specify such dependencies: Depends on Dxxx in the commit message, or manually add one via Edit Related Revisions. With that, arc patch would have done the right thing.