Add kconf_update file to migrate new sidebar/statusbar config entries

Authored by muhlenpfordt on Feb 20 2018, 4:33 PM.



The two patches D10577 and D10687 modified some config entries for
sidebar and statusbar states.
This patch adds an update files for kconf_update to migrate the
old settings.

Test Plan

Manual test with kconf_update gwenview.upd converts
~/.config/gwenviewrc. Hint: There can be different versions of
kconf_update on a system, take care to use the kf5 version.
Tested with make install to automatically update by KDE.

Diff Detail

R260 Gwenview
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Feb 20 2018, 4:33 PM
muhlenpfordt created this revision.
muhlenpfordt added inline comments.

Should we use a version as update ID / which one? Or another descriptive name?

rkflx added a subscriber: rkflx.Feb 21 2018, 11:04 PM

Will look at this at a more appropriate time, because we should get this 100% right.


Looking at /usr/share/kconf_update/, it's all over the place.

Not sure the version is really relevant, though, think of upgrading from 17.08 to 18.12.

Perhaps SideBar_StatusBar_Rename?

muhlenpfordt marked 2 inline comments as done.

Renamed update ID


It's just a distinct ID to mark this update done in ~/.config/kconf_updaterc. I think a descriptive name is really better than a (possibly incorrect) version.
It also appears in the gwenview config:

rkflx accepted this revision.Feb 22 2018, 1:28 PM

Looked at this carefully now, works great.

At first I kept pulling my hair out why [SideBar-BrowseMode] was not removed (apparently), but then I realized I needed D10687 for that. Note that Phabricator allows to specify such dependencies: Depends on Dxxx in the commit message, or manually add one via Edit Related Revisions. With that, arc patch would have done the right thing.

This revision is now accepted and ready to land.Feb 22 2018, 1:28 PM
This revision was automatically updated to reflect the committed changes.