Nice first patch! For these kinds of user-facing bugs, I like to include before-and-after screenshots, like you can see in D10357: Show high-resolution and vector logos properly in HighDPI mode.

This makes it easier for reviewers to verify the fix, and for me to feature the fix in the next week's Usability & Productivity blog post. :)

Just to confirm, you don't have commit access yet? I should commit it for you?

Yeah, I'm completely new to this. If I need permissions to something, or I did something wrong, please let me know. :)

In D10688#210247, @acrouthamel wrote:

Yeah, I'm completely new to this. If I need permissions to something, or I did something wrong, please let me know. :)

No it's fine. I just needed to know whether you can commit it yourself. I can commit it for you but I need your email
for attribution in the git commit (and name too but I can see it in your phabricator profile).

After a few patches you can easily get commit access.

Ok cool. Email: crouthamela@gmail.com

Lovely first patch.

I think you labeled the screenshots the wrong way

It looks OK to me?

Are you saying those icons should be that small?

That's just my Papirus theme, the Breeze icons aren't like that.

Note to self - Use Breeze icons in screenshots. Lol.

It does look like rendering the icons correctly in HiDPI makes some of them a bit smaller, but if that's actually problem, it's one we should solve in another patch IMHO.

I don't know the before state, but just by looking at the screenshots from my phone I like the first and the third better

In D10688#210299, @nicolasfella wrote:

I don't know the before state, but just by looking at the screenshots from my phone I like the first and the third better

First and third are clearly more pixelated.

The issue is moot; with standard Breeze icons, they don't get smaller when they're rendered correctly, so everything's fine. If there's a bug, apparently it's with the Papirus icons.

In D10688#210300, @stikonas wrote:

In D10688#210299, @nicolasfella wrote:

I don't know the before state, but just by looking at the screenshots from my phone I like the first and the third better

First and third are clearly more pixelated.

Didn't see that from my phone :)

I updated the description with new screenshots with Breeze. You can see size doesn't change. The bottom icons are blue now... but that's a Breeze thing then.

In D10688#210304, @ngraham wrote:

I think this could land. Wanna do the honors, @stikonas?

Ok, I'll commit.