Differential D10674

Fix tablet finder button registration
ClosedPublic
Actions

Authored by valeriymalov on Feb 20 2018, 12:51 AM.

Details

Reviewers
fvogt
Commits
R530:e496bd4033b6: Fix tablet finder button registration
Summary

Replace nativeEvent with mousePressEvent and get rid of XCB code (button
numbers are still X11 specific, though). Qt's XCB backend should have
support for up to 31 extra button now.

Keep "Cancel" button enabled all the time

Button mapping also seems to cover stylus buttons, not just express
keys, so edit the label accordingly

Test Plan

kde_wacom_tabletfinder shouldn't skip button mapping part anymore

Diff Detail

Repository
R530 Wacom tablet support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
valeriymalov requested review of this revision.Feb 20 2018, 12:51 AM
valeriymalov created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 8:33 PM
Closed by commit R530:e496bd4033b6: Fix tablet finder button registration (authored by valeriymalov). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28984

View Options

src/tabletfinder/dialog.ui

Loading...
View Options

src/tabletfinder/hwbuttondialog.h

Loading...
View Options

src/tabletfinder/hwbuttondialog.cpp

Loading...