Details
- Reviewers
lbeltrame - Group Reviewers
Baloo - Commits
- R293:70162de9741e: indexerconfig: Describe some functions
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/lib/indexerconfig.h | ||
---|---|---|
45 | This makes it unclear if the entire path is used, (e.g. \p path) or whether some special part of the path (the dir) is used for matching. It *might* be nice to have documentation on how exactly (e.g. most-specific wins) the matching works, unless that is documented elsewhere. | |
47 | Is \p true really the right markup here? That's for parameters. You probably want \c true -- even though that will produce exactly the same output, the meaning is different. | |
52 | What does "cached and cleaned up" mean here? (Same applies below) | |
71 | What does "perfectly possible" mean here? This might need one or more examples, or a link to how in- and ex-clusion works. |
- fileindexerconfig: Make descriptions consistent
- indexerconfig: Make descriptions consistent
src/lib/indexerconfig.h | ||
---|---|---|
52 | Here, nothing :-) |
src/lib/indexerconfig.h | ||
---|---|---|
45 | Ouch... This one hurts, but it's to the best of my abilities in English. |
src/file/fileindexerconfig.h | ||
---|---|---|
27 | I just noticed this. Can you do the #include changes as part of a separate commit? |