indexerconfig: Expose canBeSearched function
ClosedPublic
Actions

Authored by michaelh on Feb 19 2018, 4:05 PM.

Details

Reviewers

dfaure
lbeltrame

Group Reviewers

Baloo
Dolphin

Commits

Summary

Make D10205 public

CCBUG:388656

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

michaelh requested review of this revision.Feb 19 2018, 4:05 PM

adridg added inline comments.

src/lib/indexerconfig.h
42	This description says only `includeFolders()` is taken into account. The next paragraph says "should be indexed", which suggests that the function `shouldBeIndexed()` is involved -- but that does a whole different set of checks, also using the excludes. Either rephrase to avoid the "should be indexed" verb here, or make more clear what exactly the criterium is.
47	Probably `\c true`, see also D10662.

michaelh marked 2 inline comments as done.Feb 21 2018, 11:08 AM

For what it's worth, LGTM .

This revision is now accepted and ready to land.Feb 22 2018, 1:03 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/indexerconfig.h (11 lines)
M			src/lib/indexerconfig.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27551	94da185		Feb 19 2018, 4:01 PM	★	★
Diff 2	27667	94da185	- indexerconfig: Rephrase description	Feb 21 2018, 11:00 AM	★	★
Diff 3	27788	94da185	R293:67a84fe99a03df4e455c8c543c8dfe94a533e970	Feb 22 2018, 2:25 PM	★	★