Fixes opening recent and search URLs from it.
Details
- Reviewers
elvisangelaccio rkflx - Group Reviewers
Frameworks - Commits
- R241:27452b50d3b6: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl
Disabled Places sidebar in Dolphin, clicked the url navigator places selector and successfully opened the "Search for Images" place. Before Dolphin would complain that "search" isn't a known protocol
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This fix looks pretty much just like a patch I have lying around somewhere. Still I wonder whether we should monkey-patch all present and future users of KFilePlacesModel instead of fixing a single location? Last time I looked at it this was Baloo (e.g. TimelineProtocol::listDir, parseTimelineUrl etc., but I might be wrong on the connection to the search:/ case).
Tested this in several apps, works as it should. Code LGTM.
I'd say we should get this patch in right now, we can always figure out a better solution later. After all, KFilePlacesModel::convertedUrl was introduced for a reason.