[Run Command] Add history drop down button
ClosedPublic
Actions

Authored by broulik on Feb 19 2018, 10:36 AM.

Details

Reviewers

None

Group Reviewers

Plasma
VDG

Commits

Summary

Indicates that there's a "drop down" history similar to a ComboBox. The fact that you can press the down arrow to bring it up is hardly discoverable.

BUG: 375207
FIXED-IN: 5.13.0

Test Plan

When the text field is empty, a drop down arrow is shown in the text field. As soon as you type it is replaced by the regular "clear" button

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Feb 19 2018, 10:36 AM

Indeed; I never discovered it! This is great.

lookandfeel/contents/runcommand/RunCommand.qml
125 ↗	(On Diff #27525)	Do we have a programmatic value we can use here instead of a magic number?
129 ↗	(On Diff #27525)	Ditto; maybe we should make `units.iconSizes.small` reflect the actual size that we want and just use that?

Those magic values are copied straight from Plasma TextFieldStyle

I imagine refactoring that not to use magic numbers is a bigger effort. Still, we should keep that in mind, I think.

VDG-wise, big thumbs up. This is a clear usability improvement.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Wonderful! The famous arrow has come back! It should not have been removed in the first place!

			Path	Packages
M			lookandfeel/contents/runcommand/RunCommand.qml (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27525			Feb 19 2018, 10:33 AM	★	★
Diff 2	27541	745cffc	R120:8227e4e2b7f034166cbf5efb01e4e715028b4606	Feb 19 2018, 2:09 PM	★	★