Differential D10642

[kcmkwin/rules] Disable detect button on Wayland
ClosedPublic
Actions

Authored by graesslin on Feb 18 2018, 5:06 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Commits
R108:6d6576f81932: [kcmkwin/rules] Disable detect button on Wayland
Summary

The detect functionality is still extremely bound to X11 and results in
a crash when clicked. Thus it's better to disable it completely in 5.12
on Wayland.

Test Plan

Button disabled on Wayland, enabled on X11

Diff Detail

Repository
R108 KWin
Branch
detect-button-disabled-5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Feb 18 2018, 5:06 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 18 2018, 5:06 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 18 2018, 5:06 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 18 2018, 5:06 PM
ngraham added a subscriber: ngraham.Feb 18 2018, 11:01 PM

Maybe we should just remove it instead of disabling it? Otherwise people will wonder why it's disabled and sitting there, taunting them. Alternatively, an informative tooltip explaining the issue would work too.

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 18 2018, 11:01 PM
graesslin added a comment.Feb 19 2018, 5:29 AM

Tooltip is not possible, we are in string freeze. I can of course hide the button, but then users might be wondering where it has gone. Given that I doubt it makes much difference.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 19 2018, 5:29 AM
davidedmundson accepted this revision.Feb 19 2018, 8:53 AM
This revision is now accepted and ready to land.Feb 19 2018, 8:53 AM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 19 2018, 8:53 AM
mart added a subscriber: mart.Feb 19 2018, 2:49 PM

i also wonder if wouldn't be better to hide it as that button could never ever be enabled at all in wayland (at least.. i guess?)

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 19 2018, 2:49 PM
graesslin updated this revision to Diff 27555.Feb 19 2018, 4:47 PM

Hide buttons intead of disabling them

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 19 2018, 4:47 PM
Closed by commit R108:6d6576f81932: [kcmkwin/rules] Disable detect button on Wayland (authored by graesslin). · Explain WhyMar 4 2018, 8:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcmkwin/kwinrules/ruleswidget.cpp (2 lines)

Diff 27555

View Options

kcmkwin/kwinrules/ruleswidget.cpp

Loading...