Update aqbanking to 5.7.8
ClosedPublic

Authored by wojnilowicz on Feb 18 2018, 3:46 PM.

Details

Summary

Hannah could you read comment in D10443 and answer, because I see it's still not fixed?

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz requested review of this revision.Feb 18 2018, 3:46 PM
wojnilowicz created this revision.
vonreth requested changes to this revision.Feb 19 2018, 8:20 AM
vonreth added inline comments.
autotools/gwenhywfar/gwenhywfar.py
46

I think patching the build system would be cleaner....
Also please apply that patch only with OsUtils.isWin()

This revision now requires changes to proceed.Feb 19 2018, 8:20 AM
autotools/gwenhywfar/gwenhywfar.py
46

What do you mean by patching the build system?
I'm already patching the build directory.

vonreth added inline comments.Feb 19 2018, 6:06 PM
autotools/gwenhywfar/gwenhywfar.py
46

I mean to patch the file that generates the config file with a static patch file instead of using this dynamic code

wojnilowicz added inline comments.Feb 19 2018, 6:52 PM
autotools/gwenhywfar/gwenhywfar.py
46

Ok, that's almost doable, but how would you patch the following line?

set_and_check(prefix "@prefix@")

which expands to

set_and_check(prefix "/r")

and I need it to be

set_and_check(prefix "R:")

Right now I search for "/r" and change it to "R:".

vonreth added inline comments.Feb 19 2018, 7:51 PM
autotools/gwenhywfar/gwenhywfar.py
46

I hate autotools.....
Pls keep your code but put it into an if windows...

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 23 2018, 3:59 PM
This revision was automatically updated to reflect the committed changes.