Differential D10633

Use 22px battery and keyboard icon in lock screen and sddm
Needs RevisionPublic
Actions

Authored by guoyunhe on Feb 18 2018, 12:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Workspaces
Summary

ToolButton and Battery components are using 16px icons but here is no 16px icons in Breeze theme and others for
battery and virtual keyboard. Using a scaled icon in 16px is ugly. This patch forces the screen locker and sddm theme UI to use 22px icons.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
guoyunhe created this revision.Feb 18 2018, 12:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2018, 12:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Feb 18 2018, 12:57 PM
guoyunhe edited the summary of this revision. (Show Details)Feb 18 2018, 1:00 PM
davidedmundson requested changes to this revision.Feb 18 2018, 10:02 PM
davidedmundson added a subscriber: davidedmundson.

Analysis seems fine.

Solution can be better. Lets try to avoid any hardcoded values. You can get icon sizes from the Units too.

components/workspace/BatteryIcon.qml
42

so the icon will be bigger than the parent?

That's messy

sddm-theme/Main.qml
299

currently this is based on the implicitHeight of the biggest child item, we shouldn't be hardcoding things here.

This revision now requires changes to proceed.Feb 18 2018, 10:02 PM

Revision Contents
Changeset List

Diff 27465

View Options

components/workspace/BatteryIcon.qml

Loading...
View Options

lookandfeel/contents/lockscreen/LockScreenUi.qml

Loading...
View Options

sddm-theme/Main.qml

Loading...