Avoid a double emitResult()
ClosedPublic
Actions

Authored by jtamate on Feb 18 2018, 10:16 AM.

Details

Reviewers

Group Reviewers

Frameworks
Plasma

Commits

R120:4b68374192ac: Avoid a double emitResult()

Summary

ServiceJob::setResult already does a emitResult.
Discovered with the assert created in https://phabricator.kde.org/D9862

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

jtamate requested review of this revision.Feb 18 2018, 10:16 AM

A quick search through plasma codebase reveals that setResult followed by emitResult is done quite often. Care to fix these, too? :)

This revision is now accepted and ready to land.Feb 18 2018, 4:45 PM

I haven't found more instances of setResult followed by emitResult.

dataengines/places/setupdevicejob.cpp
dataengines/mpris2/playeractionjob.cpp
dataengines/applicationjobs/jobaction.cpp

In D10629#209358, @broulik wrote:

I did a objdump -d to be sure:

dataengines/places/setupdevicejob.cpp

setError is from KJob and it only sets a member value (d->error = errorCode;)

dataengines/mpris2/playeractionjob.cpp

setErrorText is from KJob also and it only sets a member value (d->errorText = errorText;)

dataengines/applicationjobs/jobaction.cpp

The same as the other two.

Okay, nevermind. Go for it then!

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			dataengines/notifications/notificationaction.cpp (2 lines)
M			klipper/clipboardjob.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27456	de16179		Feb 18 2018, 10:16 AM	★	★
Diff 2	27523			Feb 19 2018, 9:28 AM	★	★
Diff 3	27571	8227e4e	R120:4b68374192acff42e6331f37bb4c278e31e51569	Feb 19 2018, 7:31 PM	★	★