INFORMATIONAL: Make plasma-workspace compile
AbandonedPublic

Authored by michaelh on Feb 18 2018, 8:42 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Plasma: Workspaces
Summary

This diff is purely informational.

Without this patch compilation of plasma-workspace fails with:

~/bin/kde-latest/include/ksysguard/processcore/processes.h:61:54: error: ‘null’ is not a member of ‘QString’
         Processes(const QString &hostname = QString::null, QObject * parent = nullptr);
                                                      ^~~~
make[2]: *** [systemmonitor/CMakeFiles/systemmonitor.dir/build.make:63: systemmonitor/CMakeFiles/systemmonitor.dir/ksystemactivitydialog.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3206: systemmonitor/CMakeFiles/systemmonitor.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
*** Failure: Exit code 2 **

Maybe this is a real fix, may not.
BTW, I'm very curious to know why libksysguard and ksysguard compile without this patch, while plasma-workspace does not.

Diff Detail

Repository
R111 KSysguard Library
Branch
plasma (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Feb 18 2018, 8:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2018, 8:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
michaelh requested review of this revision.Feb 18 2018, 8:42 AM
michaelh edited the summary of this revision. (Show Details)
apol added a subscriber: apol.Feb 18 2018, 2:41 PM

Are you sure you are up to date? 235fa3ea97d7226a6e5c8859fe7e1cd5c3cf8b0c should fix it.

michaelh abandoned this revision.Feb 18 2018, 3:13 PM

@apol: It compiles now. But something is strange. This is what I did for D10624:
`$ kdesrc-build plasma-workspace'
did not compile
$ zypper si -d plasma-workspace
did not compile error in description
$ kdesrc-build libksysguard
did not compile, same error
...
after your response
$ git pull
:-)

Now, where is the error?