My first bugfix. Un-mangled the ConfigGeneral.qml file for the stock Media Frame plasmoid, based on bug 390571. Hope I chose the right reviewers.

Can someone (David?) land this for me? I don't have the superpowers to do it myself.

Thanks!

We'll need an email address for you first. What's a good one?

My email is

bundito@gmail.com

My KDE Identity username is

sharvey

Although if you see me on IRC, I am

bundito

Thanks!

Thanks! Also please address @davidedmundson's requests and revert the changes from Label to Text and the new Arabic translations (translation is done via another process).

And please make sure that it still works with the return to using a Label.

My apologies. I thought his changes were already made. I'm new to this whole process. I don't know how the Text item changed; I didn't do any work on that file. And now the change doesn't show up in the resubmitted diff. It is currently a Label and works just fine.

My mistake was doing my work on the copy installed in my system as opposed to the version pulled fresh from git. I assumed they were the same. I won't make that mistake again.

No worries! There's always a bit of a learning curve here. You might check out https://community.kde.org/Infrastructure/Phabricator, which outlines some sane workflows for Phabricator.

The new Arabic translations in applets/mediaframe/package/metadata.desktop still need to be removed FYI.

Arabic translations REMOVED. Now I understand. I thought I had typo'ed and accidentally changed them originally. I'm trying, I'm trying!

Thanks! I'll let @davidedmundson push this if he's satisfied with the changes.

In D10618#209247, @ngraham wrote:

Thanks! I'll let @davidedmundson push this if he's satisfied with the changes.

Sounds fair to me. Thanks for the guidance. Now back to trying to fix my video drivers...