Fix ComboBox & mode description for image fill mode

Authored by sharvey on Feb 17 2018, 10:21 PM.



BUG: 390571

Reworked ConfigGeneral.qml to properly display ComboBox for image
fill modes, along with descriptive message explaining fill mode.

Changed default change interval (main.xml) to 10.0 instead of the
random-appearing 6.8 original.

(Minor) Capitalized "Frame" in plasmoid title as "Media Frame"

Diff Detail

R114 Plasma Addons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sharvey created this revision.Feb 17 2018, 10:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2018, 10:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Feb 17 2018, 10:21 PM

My first bugfix. Un-mangled the ConfigGeneral.qml file for the stock Media Frame plasmoid, based on bug 390571. Hope I chose the right reviewers.

davidedmundson accepted this revision.Feb 17 2018, 10:41 PM

1 minor fix.

Make sure you don't change the Arabic translations when pushing.

161 ↗(On Diff #27433)

Always label.

This revision is now accepted and ready to land.Feb 17 2018, 10:41 PM

Can someone (David?) land this for me? I don't have the superpowers to do it myself.


We'll need an email address for you first. What's a good one?

My email is

My KDE Identity username is


Although if you see me on IRC, I am



ngraham added a comment.EditedFeb 19 2018, 1:04 AM

Thanks! Also please address @davidedmundson's requests and revert the changes from Label to Text and the new Arabic translations (translation is done via another process).

And please make sure that it still works with the return to using a Label.

sharvey updated this revision to Diff 27507.Feb 19 2018, 1:20 AM
  • Change "Text" item to preferred "Label" item

My apologies. I thought his changes were already made. I'm new to this whole process. I don't know how the Text item changed; I didn't do any work on that file. And now the change doesn't show up in the resubmitted diff. It is currently a Label and works just fine.

My mistake was doing my work on the copy installed in my system as opposed to the version pulled fresh from git. I assumed they were the same. I won't make that mistake again.

No worries! There's always a bit of a learning curve here. You might check out, which outlines some sane workflows for Phabricator.

The new Arabic translations in applets/mediaframe/package/metadata.desktop still need to be removed FYI.

sharvey updated this revision to Diff 27508.Feb 19 2018, 1:38 AM
  • Removed new Arabic translations from metadata.desktop

Arabic translations REMOVED. Now I understand. I thought I had typo'ed and accidentally changed them originally. I'm trying, I'm trying!

Thanks! I'll let @davidedmundson push this if he's satisfied with the changes.

Thanks! I'll let @davidedmundson push this if he's satisfied with the changes.

Sounds fair to me. Thanks for the guidance. Now back to trying to fix my video drivers...

This revision was automatically updated to reflect the committed changes.