[lookandfeel kcm] Do not declare plugin in lookandfeeltool code version, v2
ClosedPublic

Authored by kossebau on Feb 17 2018, 3:55 PM.

Details

Summary

Also improves race condition on creating the JSON file and running
automoc over the cpp file which refers to it, given there is no
dependency chain defined at all for the lookandfeeltool target and
that kcm_lookandfeel.json, which was prone to make highly parallel
builds fail

Moving the K_PLUGIN_FACTORY_WITH_JSON into a separate file only added
to the sources of kcm_lookandfeel, instead of hiding with an ifndef for
the build of the lookandfeeltool target as tried before, should avoid
any potential confusion of automoc as reported from some builds
(on KDE neon?).

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Feb 17 2018, 3:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2018, 3:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Feb 17 2018, 3:55 PM

Taking the comments on D10450 about this patch as implicit +1 and going to push now, so there is 2 more days of build testing before the next release.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2018, 10:50 PM
This revision was automatically updated to reflect the committed changes.