Disable window rule configuration for Wayland
ClosedPublic

Authored by graesslin on Feb 16 2018, 7:59 PM.

Details

Summary

The window rule detection is too bound to X11 for it to work for
Wayland windows. In fact it results in the config module just crashing.
Thus it's better to just disable the items in the menu. As it's only for
X11 windows we can also enforce platform xcb for the rules dialog.

Test Plan

Menu disabled on Wayland window, menu enabled on Xwayland window

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 16 2018, 7:59 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 16 2018, 7:59 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 16 2018, 7:59 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 16 2018, 7:59 PM
mart added a subscriber: mart.Feb 20 2018, 10:07 AM

window rules is a feature which would "just" require the kcm reimplementation or as a principle is something which can't work on wayland?

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 20 2018, 10:07 AM
davidedmundson accepted this revision.Feb 20 2018, 6:23 PM
This revision is now accepted and ready to land.Feb 20 2018, 6:23 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 20 2018, 6:23 PM
In D10594#209972, @mart wrote:

window rules is a feature which would "just" require the kcm reimplementation or as a principle is something which can't work on wayland?

See D10490

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 20 2018, 6:56 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 21 2018, 5:07 PM