Differential D10592

fix RTL appearance for ComboBox
ClosedPublic
Actions

Authored by mvourlakos on Feb 16 2018, 6:35 PM.

Details

Reviewers
mart
safaalfulaij
Group Reviewers
Plasma
Commits
R242:1ff405cca5b3: fix RTL appearance for ComboBox
Summary
  • when the combobox isnt inside the main Item

but rather a sub-Item it doesnt inherit the
LayoutMirroring properties. This is a workaround
to handle that behavior.
QTBUG: https://bugreports.qt.io/browse/QTBUG-66446

Test Plan

checkout that LayoutMirroring works properly in
such case

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
rtl
Lint
No Linters Available
Unit
No Unit Test Coverage
mvourlakos created this revision.Feb 16 2018, 6:35 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 16 2018, 6:35 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Feb 16 2018, 6:35 PM
safaalfulaij added a subscriber: safaalfulaij.Feb 16 2018, 9:13 PM
safaalfulaij added inline comments.
src/declarativeimports/plasmacomponents3/ComboBox.qml
113

When the ComboBox is not inside a top-level Window, it's Popup does not inherit

mvourlakos updated this revision to Diff 27382.Feb 16 2018, 10:12 PM
  • improve semantics
mvourlakos marked an inline comment as done.Feb 16 2018, 10:13 PM
mvourlakos added a comment.Feb 19 2018, 4:56 PM

@safaalfulaij is there a green light for this?

safaalfulaij added a comment.Feb 19 2018, 5:33 PM
In D10592#209670, @mvourlakos wrote:

@safaalfulaij is there a green light for this?

Sure. Go ahead and commit.

mvourlakos added a reviewer: safaalfulaij.Feb 19 2018, 5:36 PM

Sure. Go ahead and commit.

is it possible to give first the green light by accepting the review?

safaalfulaij accepted this revision.Feb 19 2018, 6:04 PM

Now since I'm a reviewer, sure :)

This revision is now accepted and ready to land.Feb 19 2018, 6:04 PM
Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored by mvourlakos). · Explain WhyFeb 19 2018, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27373

View Options

src/declarativeimports/plasmacomponents3/ComboBox.qml

Loading...