Make it possible to tweak the sorting of a resources list
ClosedPublic

Authored by apol on Feb 16 2018, 5:07 PM.

Details

Summary

Now that we have context actions shown, we can consider doing it, will need
work for the header.

BUG: 383518

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 16 2018, 5:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 16 2018, 5:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 16 2018, 5:07 PM

Huzzah! Users are going to be really happy about this. Sorting by name and size seem to work as expected. I found some issues, though:

  • We should use a dropdown menu control for this UI. Perhaps we should revive our Kirigami patch to keep the title visible when we have other actions on the header
  • RatingPointsRole appears to result in apps being sorted in reverse alphabetical order, rather than by rating:
ngraham requested changes to this revision.Feb 16 2018, 6:12 PM
This revision now requires changes to proceed.Feb 16 2018, 6:12 PM
apol updated this revision to Diff 27609.Feb 20 2018, 2:27 PM

Addressed Nate's comments

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.