Differential D10563

Place toolbox in the top right corner of the screen
ClosedPublic
Actions

Authored by broulik on Feb 15 2018, 10:14 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R119:b2588104cc56: Place toolbox in the top right corner of the screen
Summary

This moves it out of the way of desktop icons and is also what Plasma 4 did.
The code is adjusted to mirror the position for right-to-left languages.

BUG: 390038

Test Plan

The last time I tried this I had the toolbox reposition itself topleft again when it moved out of the way of a top panel but I cannot reproduce this right now, needs some more testing.

What I found odd is that the toolbox stores its configs in the containment, the toolbox' own xml file is ignored. Took me a while to find why my default change wouldn't stick..

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 15 2018, 10:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2018, 10:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 15 2018, 10:14 PM
broulik edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Feb 15 2018, 10:18 PM
ngraham added a subscriber: ngraham.

Nice!

This revision is now accepted and ready to land.Feb 15 2018, 10:18 PM
ngraham added a comment.Feb 15 2018, 10:30 PM

If and when this goes in, any chance you could land it for 5.12.x? This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12.

broulik added a comment.Feb 15 2018, 10:45 PM

If and when this goes in, any chance you could land it for 5.12.x?

Strictly speaking, this is a behavior change, feature, not a bugfix per se.

This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12.

They could have told us earlier that they're patching it… distros could also just apply this patch if they want to.

ngraham added a comment.Feb 15 2018, 10:46 PM

Apparently Kubuntu has been patching this for three years. I only found out today...

cfeck added a subscriber: cfeck.Feb 16 2018, 12:51 AM
cfeck added inline comments.
toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml
143

'determine'

davidedmundson added a subscriber: davidedmundson.Feb 19 2018, 9:48 AM

what "the toolbox' own xml file is ignored

What xml file? If it's not used, delete it.

rikmills added a comment.Feb 19 2018, 10:12 AM
In D10563#209359, @davidedmundson wrote:

what "the toolbox' own xml file is ignored

What xml file? If it's not used, delete it.

containments/desktop/package/contents/config/main.xml

It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a default setup at least.

broulik added a comment.Feb 19 2018, 10:39 AM
In D10563#209361, @rikmills wrote:
In D10563#209359, @davidedmundson wrote:

What xml file? If it's not used, delete it.

containments/desktop/package/contents/config/main.xml

It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a default setup at least.

I mean the toolboxes/desktoptoolbox/contents/config/main.xml - I thought that's where the toolbox stores its config but it turns out it just writes them to the desktop containment config (which has all the keys of this one). This looks wrong to me, though.

Closed by commit R119:b2588104cc56: Place toolbox in the top right corner of the screen (authored by broulik). · Explain WhyFeb 23 2018, 10:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27839

View Options

containments/desktop/package/contents/config/main.xml

Loading...
View Options

toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

Loading...